diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b97b445..e602dc3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,9 +34,9 @@ - **Send Pull Requests to the `dev` branch.** All Pull Requests must be sent to the `dev` branch, `master` is the latest release and PRs to that branch will be closed. -- **Ensure changes are jshint validated.** After making a change be sure to run the build process +- **Ensure changes are eslint validated.** After making a change be sure to run the build process to ensure that you didn't break anything. You can do this with `npm test` which will run -jshint, rebuild, then run the test suite. +eslint, rebuild, then run the test suite. - **Never commit new builds.** When making a code change, you should always run `npm run build` which will rebuild the project, *however* please do not commit these new builds or your PR will be closed. @@ -53,7 +53,7 @@ - Always favor strict equals `===` unless you *need* to use type coercion. -- Follow conventions already in the code, and listen to jshint. +- Follow conventions already in the code, and listen to eslint. [0]: https://github.com/pixijs/pixi.js/issues [1]: http://jsfiddle.net @@ -63,4 +63,4 @@ ## Contributor Code of Conduct -[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) \ No newline at end of file +[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b97b445..e602dc3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,9 +34,9 @@ - **Send Pull Requests to the `dev` branch.** All Pull Requests must be sent to the `dev` branch, `master` is the latest release and PRs to that branch will be closed. -- **Ensure changes are jshint validated.** After making a change be sure to run the build process +- **Ensure changes are eslint validated.** After making a change be sure to run the build process to ensure that you didn't break anything. You can do this with `npm test` which will run -jshint, rebuild, then run the test suite. +eslint, rebuild, then run the test suite. - **Never commit new builds.** When making a code change, you should always run `npm run build` which will rebuild the project, *however* please do not commit these new builds or your PR will be closed. @@ -53,7 +53,7 @@ - Always favor strict equals `===` unless you *need* to use type coercion. -- Follow conventions already in the code, and listen to jshint. +- Follow conventions already in the code, and listen to eslint. [0]: https://github.com/pixijs/pixi.js/issues [1]: http://jsfiddle.net @@ -63,4 +63,4 @@ ## Contributor Code of Conduct -[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) \ No newline at end of file +[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) diff --git a/src/core/display/DisplayObject.js b/src/core/display/DisplayObject.js index 9c105b3..15873a2 100644 --- a/src/core/display/DisplayObject.js +++ b/src/core/display/DisplayObject.js @@ -24,7 +24,7 @@ let TransformClass = CONST.TRANSFORM_MODE.DEFAULT === CONST.TRANSFORM_MODE.STATIC ? TransformStatic : Transform; this.tempDisplayObjectParent = null; - + //TODO: need to create Transform from factory /** * World transform and local transform of this object. @@ -111,8 +111,8 @@ get _tempDisplayObjectParent() { if (this.tempDisplayObjectParent === null) { this.tempDisplayObjectParent = new DisplayObject(); - } - return this.tempDisplayObjectParent; + } + return this.tempDisplayObjectParent; } /* @@ -341,7 +341,7 @@ * @param [pivotY=0] {number} The Y pivot value * @return {PIXI.DisplayObject} The DisplayObject instance */ - setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) //jshint ignore:line + setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) { this.position.x = x || 0; this.position.y = y || 0; @@ -358,7 +358,7 @@ /** * Base destroy method for generic display objects. This will automatically * remove the display object from its parent Container as well as remove - * all current event listeners and internal references. Do not use a DisplayObject + * all current event listeners and internal references. Do not use a DisplayObject * after calling `destroy`. */ destroy() @@ -531,7 +531,7 @@ return true; } - + /** * Sets a mask for the displayObject. A mask is an object that limits the visibility of an object to the shape of the mask applied to it. * In PIXI a regular mask must be a PIXI.Graphics or a PIXI.Sprite object. This allows for much faster masking in canvas as it utilises shape clipping. @@ -582,4 +582,4 @@ // performance increase to avoid using call.. (10x faster) DisplayObject.prototype.displayObjectUpdateTransform = DisplayObject.prototype.updateTransform; -export default DisplayObject; \ No newline at end of file +export default DisplayObject; diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b97b445..e602dc3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,9 +34,9 @@ - **Send Pull Requests to the `dev` branch.** All Pull Requests must be sent to the `dev` branch, `master` is the latest release and PRs to that branch will be closed. -- **Ensure changes are jshint validated.** After making a change be sure to run the build process +- **Ensure changes are eslint validated.** After making a change be sure to run the build process to ensure that you didn't break anything. You can do this with `npm test` which will run -jshint, rebuild, then run the test suite. +eslint, rebuild, then run the test suite. - **Never commit new builds.** When making a code change, you should always run `npm run build` which will rebuild the project, *however* please do not commit these new builds or your PR will be closed. @@ -53,7 +53,7 @@ - Always favor strict equals `===` unless you *need* to use type coercion. -- Follow conventions already in the code, and listen to jshint. +- Follow conventions already in the code, and listen to eslint. [0]: https://github.com/pixijs/pixi.js/issues [1]: http://jsfiddle.net @@ -63,4 +63,4 @@ ## Contributor Code of Conduct -[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) \ No newline at end of file +[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) diff --git a/src/core/display/DisplayObject.js b/src/core/display/DisplayObject.js index 9c105b3..15873a2 100644 --- a/src/core/display/DisplayObject.js +++ b/src/core/display/DisplayObject.js @@ -24,7 +24,7 @@ let TransformClass = CONST.TRANSFORM_MODE.DEFAULT === CONST.TRANSFORM_MODE.STATIC ? TransformStatic : Transform; this.tempDisplayObjectParent = null; - + //TODO: need to create Transform from factory /** * World transform and local transform of this object. @@ -111,8 +111,8 @@ get _tempDisplayObjectParent() { if (this.tempDisplayObjectParent === null) { this.tempDisplayObjectParent = new DisplayObject(); - } - return this.tempDisplayObjectParent; + } + return this.tempDisplayObjectParent; } /* @@ -341,7 +341,7 @@ * @param [pivotY=0] {number} The Y pivot value * @return {PIXI.DisplayObject} The DisplayObject instance */ - setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) //jshint ignore:line + setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) { this.position.x = x || 0; this.position.y = y || 0; @@ -358,7 +358,7 @@ /** * Base destroy method for generic display objects. This will automatically * remove the display object from its parent Container as well as remove - * all current event listeners and internal references. Do not use a DisplayObject + * all current event listeners and internal references. Do not use a DisplayObject * after calling `destroy`. */ destroy() @@ -531,7 +531,7 @@ return true; } - + /** * Sets a mask for the displayObject. A mask is an object that limits the visibility of an object to the shape of the mask applied to it. * In PIXI a regular mask must be a PIXI.Graphics or a PIXI.Sprite object. This allows for much faster masking in canvas as it utilises shape clipping. @@ -582,4 +582,4 @@ // performance increase to avoid using call.. (10x faster) DisplayObject.prototype.displayObjectUpdateTransform = DisplayObject.prototype.updateTransform; -export default DisplayObject; \ No newline at end of file +export default DisplayObject; diff --git a/src/core/graphics/utils/bezierCurveTo.js b/src/core/graphics/utils/bezierCurveTo.js index 14b799e..456d07c 100644 --- a/src/core/graphics/utils/bezierCurveTo.js +++ b/src/core/graphics/utils/bezierCurveTo.js @@ -16,7 +16,7 @@ * @param [path=number[]] Path array to push points into * @return {PIXI.Graphics} */ -const bezierCurveTo = function (fromX, fromY, cpX, cpY, cpX2, cpY2, toX, toY, path) // jshint ignore:line +const bezierCurveTo = function (fromX, fromY, cpX, cpY, cpX2, cpY2, toX, toY, path) { path = path || []; diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b97b445..e602dc3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,9 +34,9 @@ - **Send Pull Requests to the `dev` branch.** All Pull Requests must be sent to the `dev` branch, `master` is the latest release and PRs to that branch will be closed. -- **Ensure changes are jshint validated.** After making a change be sure to run the build process +- **Ensure changes are eslint validated.** After making a change be sure to run the build process to ensure that you didn't break anything. You can do this with `npm test` which will run -jshint, rebuild, then run the test suite. +eslint, rebuild, then run the test suite. - **Never commit new builds.** When making a code change, you should always run `npm run build` which will rebuild the project, *however* please do not commit these new builds or your PR will be closed. @@ -53,7 +53,7 @@ - Always favor strict equals `===` unless you *need* to use type coercion. -- Follow conventions already in the code, and listen to jshint. +- Follow conventions already in the code, and listen to eslint. [0]: https://github.com/pixijs/pixi.js/issues [1]: http://jsfiddle.net @@ -63,4 +63,4 @@ ## Contributor Code of Conduct -[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) \ No newline at end of file +[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) diff --git a/src/core/display/DisplayObject.js b/src/core/display/DisplayObject.js index 9c105b3..15873a2 100644 --- a/src/core/display/DisplayObject.js +++ b/src/core/display/DisplayObject.js @@ -24,7 +24,7 @@ let TransformClass = CONST.TRANSFORM_MODE.DEFAULT === CONST.TRANSFORM_MODE.STATIC ? TransformStatic : Transform; this.tempDisplayObjectParent = null; - + //TODO: need to create Transform from factory /** * World transform and local transform of this object. @@ -111,8 +111,8 @@ get _tempDisplayObjectParent() { if (this.tempDisplayObjectParent === null) { this.tempDisplayObjectParent = new DisplayObject(); - } - return this.tempDisplayObjectParent; + } + return this.tempDisplayObjectParent; } /* @@ -341,7 +341,7 @@ * @param [pivotY=0] {number} The Y pivot value * @return {PIXI.DisplayObject} The DisplayObject instance */ - setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) //jshint ignore:line + setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) { this.position.x = x || 0; this.position.y = y || 0; @@ -358,7 +358,7 @@ /** * Base destroy method for generic display objects. This will automatically * remove the display object from its parent Container as well as remove - * all current event listeners and internal references. Do not use a DisplayObject + * all current event listeners and internal references. Do not use a DisplayObject * after calling `destroy`. */ destroy() @@ -531,7 +531,7 @@ return true; } - + /** * Sets a mask for the displayObject. A mask is an object that limits the visibility of an object to the shape of the mask applied to it. * In PIXI a regular mask must be a PIXI.Graphics or a PIXI.Sprite object. This allows for much faster masking in canvas as it utilises shape clipping. @@ -582,4 +582,4 @@ // performance increase to avoid using call.. (10x faster) DisplayObject.prototype.displayObjectUpdateTransform = DisplayObject.prototype.updateTransform; -export default DisplayObject; \ No newline at end of file +export default DisplayObject; diff --git a/src/core/graphics/utils/bezierCurveTo.js b/src/core/graphics/utils/bezierCurveTo.js index 14b799e..456d07c 100644 --- a/src/core/graphics/utils/bezierCurveTo.js +++ b/src/core/graphics/utils/bezierCurveTo.js @@ -16,7 +16,7 @@ * @param [path=number[]] Path array to push points into * @return {PIXI.Graphics} */ -const bezierCurveTo = function (fromX, fromY, cpX, cpY, cpX2, cpY2, toX, toY, path) // jshint ignore:line +const bezierCurveTo = function (fromX, fromY, cpX, cpY, cpX2, cpY2, toX, toY, path) { path = path || []; diff --git a/src/core/graphics/webgl/utils/buildRoundedRectangle.js b/src/core/graphics/webgl/utils/buildRoundedRectangle.js index 52b0053..636e8f4 100644 --- a/src/core/graphics/webgl/utils/buildRoundedRectangle.js +++ b/src/core/graphics/webgl/utils/buildRoundedRectangle.js @@ -93,7 +93,7 @@ * @param [out] {number[]} The output array to add points into. If not passed, a new array is created. * @return {number[]} an array of points */ -let quadraticBezierCurve = function (fromX, fromY, cpX, cpY, toX, toY, out)// jshint ignore:line +let quadraticBezierCurve = function (fromX, fromY, cpX, cpY, toX, toY, out) { let xa, ya, @@ -130,4 +130,4 @@ return points; }; -export default buildRoundedRectangle; \ No newline at end of file +export default buildRoundedRectangle; diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b97b445..e602dc3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,9 +34,9 @@ - **Send Pull Requests to the `dev` branch.** All Pull Requests must be sent to the `dev` branch, `master` is the latest release and PRs to that branch will be closed. -- **Ensure changes are jshint validated.** After making a change be sure to run the build process +- **Ensure changes are eslint validated.** After making a change be sure to run the build process to ensure that you didn't break anything. You can do this with `npm test` which will run -jshint, rebuild, then run the test suite. +eslint, rebuild, then run the test suite. - **Never commit new builds.** When making a code change, you should always run `npm run build` which will rebuild the project, *however* please do not commit these new builds or your PR will be closed. @@ -53,7 +53,7 @@ - Always favor strict equals `===` unless you *need* to use type coercion. -- Follow conventions already in the code, and listen to jshint. +- Follow conventions already in the code, and listen to eslint. [0]: https://github.com/pixijs/pixi.js/issues [1]: http://jsfiddle.net @@ -63,4 +63,4 @@ ## Contributor Code of Conduct -[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) \ No newline at end of file +[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) diff --git a/src/core/display/DisplayObject.js b/src/core/display/DisplayObject.js index 9c105b3..15873a2 100644 --- a/src/core/display/DisplayObject.js +++ b/src/core/display/DisplayObject.js @@ -24,7 +24,7 @@ let TransformClass = CONST.TRANSFORM_MODE.DEFAULT === CONST.TRANSFORM_MODE.STATIC ? TransformStatic : Transform; this.tempDisplayObjectParent = null; - + //TODO: need to create Transform from factory /** * World transform and local transform of this object. @@ -111,8 +111,8 @@ get _tempDisplayObjectParent() { if (this.tempDisplayObjectParent === null) { this.tempDisplayObjectParent = new DisplayObject(); - } - return this.tempDisplayObjectParent; + } + return this.tempDisplayObjectParent; } /* @@ -341,7 +341,7 @@ * @param [pivotY=0] {number} The Y pivot value * @return {PIXI.DisplayObject} The DisplayObject instance */ - setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) //jshint ignore:line + setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) { this.position.x = x || 0; this.position.y = y || 0; @@ -358,7 +358,7 @@ /** * Base destroy method for generic display objects. This will automatically * remove the display object from its parent Container as well as remove - * all current event listeners and internal references. Do not use a DisplayObject + * all current event listeners and internal references. Do not use a DisplayObject * after calling `destroy`. */ destroy() @@ -531,7 +531,7 @@ return true; } - + /** * Sets a mask for the displayObject. A mask is an object that limits the visibility of an object to the shape of the mask applied to it. * In PIXI a regular mask must be a PIXI.Graphics or a PIXI.Sprite object. This allows for much faster masking in canvas as it utilises shape clipping. @@ -582,4 +582,4 @@ // performance increase to avoid using call.. (10x faster) DisplayObject.prototype.displayObjectUpdateTransform = DisplayObject.prototype.updateTransform; -export default DisplayObject; \ No newline at end of file +export default DisplayObject; diff --git a/src/core/graphics/utils/bezierCurveTo.js b/src/core/graphics/utils/bezierCurveTo.js index 14b799e..456d07c 100644 --- a/src/core/graphics/utils/bezierCurveTo.js +++ b/src/core/graphics/utils/bezierCurveTo.js @@ -16,7 +16,7 @@ * @param [path=number[]] Path array to push points into * @return {PIXI.Graphics} */ -const bezierCurveTo = function (fromX, fromY, cpX, cpY, cpX2, cpY2, toX, toY, path) // jshint ignore:line +const bezierCurveTo = function (fromX, fromY, cpX, cpY, cpX2, cpY2, toX, toY, path) { path = path || []; diff --git a/src/core/graphics/webgl/utils/buildRoundedRectangle.js b/src/core/graphics/webgl/utils/buildRoundedRectangle.js index 52b0053..636e8f4 100644 --- a/src/core/graphics/webgl/utils/buildRoundedRectangle.js +++ b/src/core/graphics/webgl/utils/buildRoundedRectangle.js @@ -93,7 +93,7 @@ * @param [out] {number[]} The output array to add points into. If not passed, a new array is created. * @return {number[]} an array of points */ -let quadraticBezierCurve = function (fromX, fromY, cpX, cpY, toX, toY, out)// jshint ignore:line +let quadraticBezierCurve = function (fromX, fromY, cpX, cpY, toX, toY, out) { let xa, ya, @@ -130,4 +130,4 @@ return points; }; -export default buildRoundedRectangle; \ No newline at end of file +export default buildRoundedRectangle; diff --git a/src/core/math/Matrix.js b/src/core/math/Matrix.js index 0e90543..b74f3a7 100644 --- a/src/core/math/Matrix.js +++ b/src/core/math/Matrix.js @@ -1,7 +1,3 @@ -// @todo - ignore the too many parameters warning for now -// should either fix it or change the jshint config -// jshint -W072 - import Point from './Point'; /** @@ -491,4 +487,4 @@ } } -export default Matrix; \ No newline at end of file +export default Matrix; diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b97b445..e602dc3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,9 +34,9 @@ - **Send Pull Requests to the `dev` branch.** All Pull Requests must be sent to the `dev` branch, `master` is the latest release and PRs to that branch will be closed. -- **Ensure changes are jshint validated.** After making a change be sure to run the build process +- **Ensure changes are eslint validated.** After making a change be sure to run the build process to ensure that you didn't break anything. You can do this with `npm test` which will run -jshint, rebuild, then run the test suite. +eslint, rebuild, then run the test suite. - **Never commit new builds.** When making a code change, you should always run `npm run build` which will rebuild the project, *however* please do not commit these new builds or your PR will be closed. @@ -53,7 +53,7 @@ - Always favor strict equals `===` unless you *need* to use type coercion. -- Follow conventions already in the code, and listen to jshint. +- Follow conventions already in the code, and listen to eslint. [0]: https://github.com/pixijs/pixi.js/issues [1]: http://jsfiddle.net @@ -63,4 +63,4 @@ ## Contributor Code of Conduct -[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) \ No newline at end of file +[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) diff --git a/src/core/display/DisplayObject.js b/src/core/display/DisplayObject.js index 9c105b3..15873a2 100644 --- a/src/core/display/DisplayObject.js +++ b/src/core/display/DisplayObject.js @@ -24,7 +24,7 @@ let TransformClass = CONST.TRANSFORM_MODE.DEFAULT === CONST.TRANSFORM_MODE.STATIC ? TransformStatic : Transform; this.tempDisplayObjectParent = null; - + //TODO: need to create Transform from factory /** * World transform and local transform of this object. @@ -111,8 +111,8 @@ get _tempDisplayObjectParent() { if (this.tempDisplayObjectParent === null) { this.tempDisplayObjectParent = new DisplayObject(); - } - return this.tempDisplayObjectParent; + } + return this.tempDisplayObjectParent; } /* @@ -341,7 +341,7 @@ * @param [pivotY=0] {number} The Y pivot value * @return {PIXI.DisplayObject} The DisplayObject instance */ - setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) //jshint ignore:line + setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) { this.position.x = x || 0; this.position.y = y || 0; @@ -358,7 +358,7 @@ /** * Base destroy method for generic display objects. This will automatically * remove the display object from its parent Container as well as remove - * all current event listeners and internal references. Do not use a DisplayObject + * all current event listeners and internal references. Do not use a DisplayObject * after calling `destroy`. */ destroy() @@ -531,7 +531,7 @@ return true; } - + /** * Sets a mask for the displayObject. A mask is an object that limits the visibility of an object to the shape of the mask applied to it. * In PIXI a regular mask must be a PIXI.Graphics or a PIXI.Sprite object. This allows for much faster masking in canvas as it utilises shape clipping. @@ -582,4 +582,4 @@ // performance increase to avoid using call.. (10x faster) DisplayObject.prototype.displayObjectUpdateTransform = DisplayObject.prototype.updateTransform; -export default DisplayObject; \ No newline at end of file +export default DisplayObject; diff --git a/src/core/graphics/utils/bezierCurveTo.js b/src/core/graphics/utils/bezierCurveTo.js index 14b799e..456d07c 100644 --- a/src/core/graphics/utils/bezierCurveTo.js +++ b/src/core/graphics/utils/bezierCurveTo.js @@ -16,7 +16,7 @@ * @param [path=number[]] Path array to push points into * @return {PIXI.Graphics} */ -const bezierCurveTo = function (fromX, fromY, cpX, cpY, cpX2, cpY2, toX, toY, path) // jshint ignore:line +const bezierCurveTo = function (fromX, fromY, cpX, cpY, cpX2, cpY2, toX, toY, path) { path = path || []; diff --git a/src/core/graphics/webgl/utils/buildRoundedRectangle.js b/src/core/graphics/webgl/utils/buildRoundedRectangle.js index 52b0053..636e8f4 100644 --- a/src/core/graphics/webgl/utils/buildRoundedRectangle.js +++ b/src/core/graphics/webgl/utils/buildRoundedRectangle.js @@ -93,7 +93,7 @@ * @param [out] {number[]} The output array to add points into. If not passed, a new array is created. * @return {number[]} an array of points */ -let quadraticBezierCurve = function (fromX, fromY, cpX, cpY, toX, toY, out)// jshint ignore:line +let quadraticBezierCurve = function (fromX, fromY, cpX, cpY, toX, toY, out) { let xa, ya, @@ -130,4 +130,4 @@ return points; }; -export default buildRoundedRectangle; \ No newline at end of file +export default buildRoundedRectangle; diff --git a/src/core/math/Matrix.js b/src/core/math/Matrix.js index 0e90543..b74f3a7 100644 --- a/src/core/math/Matrix.js +++ b/src/core/math/Matrix.js @@ -1,7 +1,3 @@ -// @todo - ignore the too many parameters warning for now -// should either fix it or change the jshint config -// jshint -W072 - import Point from './Point'; /** @@ -491,4 +487,4 @@ } } -export default Matrix; \ No newline at end of file +export default Matrix; diff --git a/src/core/renderers/webgl/managers/FilterManager.js b/src/core/renderers/webgl/managers/FilterManager.js index f1d5a99..bf59404 100644 --- a/src/core/renderers/webgl/managers/FilterManager.js +++ b/src/core/renderers/webgl/managers/FilterManager.js @@ -440,4 +440,4 @@ } } -export default FilterManager; \ No newline at end of file +export default FilterManager; diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b97b445..e602dc3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,9 +34,9 @@ - **Send Pull Requests to the `dev` branch.** All Pull Requests must be sent to the `dev` branch, `master` is the latest release and PRs to that branch will be closed. -- **Ensure changes are jshint validated.** After making a change be sure to run the build process +- **Ensure changes are eslint validated.** After making a change be sure to run the build process to ensure that you didn't break anything. You can do this with `npm test` which will run -jshint, rebuild, then run the test suite. +eslint, rebuild, then run the test suite. - **Never commit new builds.** When making a code change, you should always run `npm run build` which will rebuild the project, *however* please do not commit these new builds or your PR will be closed. @@ -53,7 +53,7 @@ - Always favor strict equals `===` unless you *need* to use type coercion. -- Follow conventions already in the code, and listen to jshint. +- Follow conventions already in the code, and listen to eslint. [0]: https://github.com/pixijs/pixi.js/issues [1]: http://jsfiddle.net @@ -63,4 +63,4 @@ ## Contributor Code of Conduct -[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) \ No newline at end of file +[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) diff --git a/src/core/display/DisplayObject.js b/src/core/display/DisplayObject.js index 9c105b3..15873a2 100644 --- a/src/core/display/DisplayObject.js +++ b/src/core/display/DisplayObject.js @@ -24,7 +24,7 @@ let TransformClass = CONST.TRANSFORM_MODE.DEFAULT === CONST.TRANSFORM_MODE.STATIC ? TransformStatic : Transform; this.tempDisplayObjectParent = null; - + //TODO: need to create Transform from factory /** * World transform and local transform of this object. @@ -111,8 +111,8 @@ get _tempDisplayObjectParent() { if (this.tempDisplayObjectParent === null) { this.tempDisplayObjectParent = new DisplayObject(); - } - return this.tempDisplayObjectParent; + } + return this.tempDisplayObjectParent; } /* @@ -341,7 +341,7 @@ * @param [pivotY=0] {number} The Y pivot value * @return {PIXI.DisplayObject} The DisplayObject instance */ - setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) //jshint ignore:line + setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) { this.position.x = x || 0; this.position.y = y || 0; @@ -358,7 +358,7 @@ /** * Base destroy method for generic display objects. This will automatically * remove the display object from its parent Container as well as remove - * all current event listeners and internal references. Do not use a DisplayObject + * all current event listeners and internal references. Do not use a DisplayObject * after calling `destroy`. */ destroy() @@ -531,7 +531,7 @@ return true; } - + /** * Sets a mask for the displayObject. A mask is an object that limits the visibility of an object to the shape of the mask applied to it. * In PIXI a regular mask must be a PIXI.Graphics or a PIXI.Sprite object. This allows for much faster masking in canvas as it utilises shape clipping. @@ -582,4 +582,4 @@ // performance increase to avoid using call.. (10x faster) DisplayObject.prototype.displayObjectUpdateTransform = DisplayObject.prototype.updateTransform; -export default DisplayObject; \ No newline at end of file +export default DisplayObject; diff --git a/src/core/graphics/utils/bezierCurveTo.js b/src/core/graphics/utils/bezierCurveTo.js index 14b799e..456d07c 100644 --- a/src/core/graphics/utils/bezierCurveTo.js +++ b/src/core/graphics/utils/bezierCurveTo.js @@ -16,7 +16,7 @@ * @param [path=number[]] Path array to push points into * @return {PIXI.Graphics} */ -const bezierCurveTo = function (fromX, fromY, cpX, cpY, cpX2, cpY2, toX, toY, path) // jshint ignore:line +const bezierCurveTo = function (fromX, fromY, cpX, cpY, cpX2, cpY2, toX, toY, path) { path = path || []; diff --git a/src/core/graphics/webgl/utils/buildRoundedRectangle.js b/src/core/graphics/webgl/utils/buildRoundedRectangle.js index 52b0053..636e8f4 100644 --- a/src/core/graphics/webgl/utils/buildRoundedRectangle.js +++ b/src/core/graphics/webgl/utils/buildRoundedRectangle.js @@ -93,7 +93,7 @@ * @param [out] {number[]} The output array to add points into. If not passed, a new array is created. * @return {number[]} an array of points */ -let quadraticBezierCurve = function (fromX, fromY, cpX, cpY, toX, toY, out)// jshint ignore:line +let quadraticBezierCurve = function (fromX, fromY, cpX, cpY, toX, toY, out) { let xa, ya, @@ -130,4 +130,4 @@ return points; }; -export default buildRoundedRectangle; \ No newline at end of file +export default buildRoundedRectangle; diff --git a/src/core/math/Matrix.js b/src/core/math/Matrix.js index 0e90543..b74f3a7 100644 --- a/src/core/math/Matrix.js +++ b/src/core/math/Matrix.js @@ -1,7 +1,3 @@ -// @todo - ignore the too many parameters warning for now -// should either fix it or change the jshint config -// jshint -W072 - import Point from './Point'; /** @@ -491,4 +487,4 @@ } } -export default Matrix; \ No newline at end of file +export default Matrix; diff --git a/src/core/renderers/webgl/managers/FilterManager.js b/src/core/renderers/webgl/managers/FilterManager.js index f1d5a99..bf59404 100644 --- a/src/core/renderers/webgl/managers/FilterManager.js +++ b/src/core/renderers/webgl/managers/FilterManager.js @@ -440,4 +440,4 @@ } } -export default FilterManager; \ No newline at end of file +export default FilterManager; diff --git a/src/core/renderers/webgl/utils/validateContext.js b/src/core/renderers/webgl/utils/validateContext.js index d1f83e7..34d4c88 100644 --- a/src/core/renderers/webgl/utils/validateContext.js +++ b/src/core/renderers/webgl/utils/validateContext.js @@ -5,8 +5,8 @@ // this is going to be fairly simple for now.. but at least we have rom to grow! if(!attributes.stencil) { - console.warn('Provided WebGL context does not have a stencil buffer, masks may not render correctly'); // jshint ignore:line + console.warn('Provided WebGL context does not have a stencil buffer, masks may not render correctly'); } } -export default validateContext; \ No newline at end of file +export default validateContext; diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b97b445..e602dc3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,9 +34,9 @@ - **Send Pull Requests to the `dev` branch.** All Pull Requests must be sent to the `dev` branch, `master` is the latest release and PRs to that branch will be closed. -- **Ensure changes are jshint validated.** After making a change be sure to run the build process +- **Ensure changes are eslint validated.** After making a change be sure to run the build process to ensure that you didn't break anything. You can do this with `npm test` which will run -jshint, rebuild, then run the test suite. +eslint, rebuild, then run the test suite. - **Never commit new builds.** When making a code change, you should always run `npm run build` which will rebuild the project, *however* please do not commit these new builds or your PR will be closed. @@ -53,7 +53,7 @@ - Always favor strict equals `===` unless you *need* to use type coercion. -- Follow conventions already in the code, and listen to jshint. +- Follow conventions already in the code, and listen to eslint. [0]: https://github.com/pixijs/pixi.js/issues [1]: http://jsfiddle.net @@ -63,4 +63,4 @@ ## Contributor Code of Conduct -[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) \ No newline at end of file +[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) diff --git a/src/core/display/DisplayObject.js b/src/core/display/DisplayObject.js index 9c105b3..15873a2 100644 --- a/src/core/display/DisplayObject.js +++ b/src/core/display/DisplayObject.js @@ -24,7 +24,7 @@ let TransformClass = CONST.TRANSFORM_MODE.DEFAULT === CONST.TRANSFORM_MODE.STATIC ? TransformStatic : Transform; this.tempDisplayObjectParent = null; - + //TODO: need to create Transform from factory /** * World transform and local transform of this object. @@ -111,8 +111,8 @@ get _tempDisplayObjectParent() { if (this.tempDisplayObjectParent === null) { this.tempDisplayObjectParent = new DisplayObject(); - } - return this.tempDisplayObjectParent; + } + return this.tempDisplayObjectParent; } /* @@ -341,7 +341,7 @@ * @param [pivotY=0] {number} The Y pivot value * @return {PIXI.DisplayObject} The DisplayObject instance */ - setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) //jshint ignore:line + setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) { this.position.x = x || 0; this.position.y = y || 0; @@ -358,7 +358,7 @@ /** * Base destroy method for generic display objects. This will automatically * remove the display object from its parent Container as well as remove - * all current event listeners and internal references. Do not use a DisplayObject + * all current event listeners and internal references. Do not use a DisplayObject * after calling `destroy`. */ destroy() @@ -531,7 +531,7 @@ return true; } - + /** * Sets a mask for the displayObject. A mask is an object that limits the visibility of an object to the shape of the mask applied to it. * In PIXI a regular mask must be a PIXI.Graphics or a PIXI.Sprite object. This allows for much faster masking in canvas as it utilises shape clipping. @@ -582,4 +582,4 @@ // performance increase to avoid using call.. (10x faster) DisplayObject.prototype.displayObjectUpdateTransform = DisplayObject.prototype.updateTransform; -export default DisplayObject; \ No newline at end of file +export default DisplayObject; diff --git a/src/core/graphics/utils/bezierCurveTo.js b/src/core/graphics/utils/bezierCurveTo.js index 14b799e..456d07c 100644 --- a/src/core/graphics/utils/bezierCurveTo.js +++ b/src/core/graphics/utils/bezierCurveTo.js @@ -16,7 +16,7 @@ * @param [path=number[]] Path array to push points into * @return {PIXI.Graphics} */ -const bezierCurveTo = function (fromX, fromY, cpX, cpY, cpX2, cpY2, toX, toY, path) // jshint ignore:line +const bezierCurveTo = function (fromX, fromY, cpX, cpY, cpX2, cpY2, toX, toY, path) { path = path || []; diff --git a/src/core/graphics/webgl/utils/buildRoundedRectangle.js b/src/core/graphics/webgl/utils/buildRoundedRectangle.js index 52b0053..636e8f4 100644 --- a/src/core/graphics/webgl/utils/buildRoundedRectangle.js +++ b/src/core/graphics/webgl/utils/buildRoundedRectangle.js @@ -93,7 +93,7 @@ * @param [out] {number[]} The output array to add points into. If not passed, a new array is created. * @return {number[]} an array of points */ -let quadraticBezierCurve = function (fromX, fromY, cpX, cpY, toX, toY, out)// jshint ignore:line +let quadraticBezierCurve = function (fromX, fromY, cpX, cpY, toX, toY, out) { let xa, ya, @@ -130,4 +130,4 @@ return points; }; -export default buildRoundedRectangle; \ No newline at end of file +export default buildRoundedRectangle; diff --git a/src/core/math/Matrix.js b/src/core/math/Matrix.js index 0e90543..b74f3a7 100644 --- a/src/core/math/Matrix.js +++ b/src/core/math/Matrix.js @@ -1,7 +1,3 @@ -// @todo - ignore the too many parameters warning for now -// should either fix it or change the jshint config -// jshint -W072 - import Point from './Point'; /** @@ -491,4 +487,4 @@ } } -export default Matrix; \ No newline at end of file +export default Matrix; diff --git a/src/core/renderers/webgl/managers/FilterManager.js b/src/core/renderers/webgl/managers/FilterManager.js index f1d5a99..bf59404 100644 --- a/src/core/renderers/webgl/managers/FilterManager.js +++ b/src/core/renderers/webgl/managers/FilterManager.js @@ -440,4 +440,4 @@ } } -export default FilterManager; \ No newline at end of file +export default FilterManager; diff --git a/src/core/renderers/webgl/utils/validateContext.js b/src/core/renderers/webgl/utils/validateContext.js index d1f83e7..34d4c88 100644 --- a/src/core/renderers/webgl/utils/validateContext.js +++ b/src/core/renderers/webgl/utils/validateContext.js @@ -5,8 +5,8 @@ // this is going to be fairly simple for now.. but at least we have rom to grow! if(!attributes.stencil) { - console.warn('Provided WebGL context does not have a stencil buffer, masks may not render correctly'); // jshint ignore:line + console.warn('Provided WebGL context does not have a stencil buffer, masks may not render correctly'); } } -export default validateContext; \ No newline at end of file +export default validateContext; diff --git a/src/core/textures/RenderTexture.js b/src/core/textures/RenderTexture.js index 38233d5..f0a6382 100644 --- a/src/core/textures/RenderTexture.js +++ b/src/core/textures/RenderTexture.js @@ -55,7 +55,7 @@ let resolution = arguments[4] || 1; // we have an old render texture.. - console.warn('v4 RenderTexture now expects a new BaseRenderTexture. Please use RenderTexture.create('+width+', '+height+')'); // jshint ignore:line + console.warn(`v4 RenderTexture now expects a new BaseRenderTexture. Please use RenderTexture.create(${width}, ${height})`); _legacyRenderer = arguments[0]; frame = null; @@ -122,4 +122,4 @@ } } -export default RenderTexture; \ No newline at end of file +export default RenderTexture; diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md index b97b445..e602dc3 100644 --- a/CONTRIBUTING.md +++ b/CONTRIBUTING.md @@ -34,9 +34,9 @@ - **Send Pull Requests to the `dev` branch.** All Pull Requests must be sent to the `dev` branch, `master` is the latest release and PRs to that branch will be closed. -- **Ensure changes are jshint validated.** After making a change be sure to run the build process +- **Ensure changes are eslint validated.** After making a change be sure to run the build process to ensure that you didn't break anything. You can do this with `npm test` which will run -jshint, rebuild, then run the test suite. +eslint, rebuild, then run the test suite. - **Never commit new builds.** When making a code change, you should always run `npm run build` which will rebuild the project, *however* please do not commit these new builds or your PR will be closed. @@ -53,7 +53,7 @@ - Always favor strict equals `===` unless you *need* to use type coercion. -- Follow conventions already in the code, and listen to jshint. +- Follow conventions already in the code, and listen to eslint. [0]: https://github.com/pixijs/pixi.js/issues [1]: http://jsfiddle.net @@ -63,4 +63,4 @@ ## Contributor Code of Conduct -[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) \ No newline at end of file +[Code of Conduct](CODE_OF_CONDUCT.md) is adapted from [Contributor Covenant, version 1.4](http://contributor-covenant.org/version/1/4) diff --git a/src/core/display/DisplayObject.js b/src/core/display/DisplayObject.js index 9c105b3..15873a2 100644 --- a/src/core/display/DisplayObject.js +++ b/src/core/display/DisplayObject.js @@ -24,7 +24,7 @@ let TransformClass = CONST.TRANSFORM_MODE.DEFAULT === CONST.TRANSFORM_MODE.STATIC ? TransformStatic : Transform; this.tempDisplayObjectParent = null; - + //TODO: need to create Transform from factory /** * World transform and local transform of this object. @@ -111,8 +111,8 @@ get _tempDisplayObjectParent() { if (this.tempDisplayObjectParent === null) { this.tempDisplayObjectParent = new DisplayObject(); - } - return this.tempDisplayObjectParent; + } + return this.tempDisplayObjectParent; } /* @@ -341,7 +341,7 @@ * @param [pivotY=0] {number} The Y pivot value * @return {PIXI.DisplayObject} The DisplayObject instance */ - setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) //jshint ignore:line + setTransform(x, y, scaleX, scaleY, rotation, skewX, skewY, pivotX, pivotY) { this.position.x = x || 0; this.position.y = y || 0; @@ -358,7 +358,7 @@ /** * Base destroy method for generic display objects. This will automatically * remove the display object from its parent Container as well as remove - * all current event listeners and internal references. Do not use a DisplayObject + * all current event listeners and internal references. Do not use a DisplayObject * after calling `destroy`. */ destroy() @@ -531,7 +531,7 @@ return true; } - + /** * Sets a mask for the displayObject. A mask is an object that limits the visibility of an object to the shape of the mask applied to it. * In PIXI a regular mask must be a PIXI.Graphics or a PIXI.Sprite object. This allows for much faster masking in canvas as it utilises shape clipping. @@ -582,4 +582,4 @@ // performance increase to avoid using call.. (10x faster) DisplayObject.prototype.displayObjectUpdateTransform = DisplayObject.prototype.updateTransform; -export default DisplayObject; \ No newline at end of file +export default DisplayObject; diff --git a/src/core/graphics/utils/bezierCurveTo.js b/src/core/graphics/utils/bezierCurveTo.js index 14b799e..456d07c 100644 --- a/src/core/graphics/utils/bezierCurveTo.js +++ b/src/core/graphics/utils/bezierCurveTo.js @@ -16,7 +16,7 @@ * @param [path=number[]] Path array to push points into * @return {PIXI.Graphics} */ -const bezierCurveTo = function (fromX, fromY, cpX, cpY, cpX2, cpY2, toX, toY, path) // jshint ignore:line +const bezierCurveTo = function (fromX, fromY, cpX, cpY, cpX2, cpY2, toX, toY, path) { path = path || []; diff --git a/src/core/graphics/webgl/utils/buildRoundedRectangle.js b/src/core/graphics/webgl/utils/buildRoundedRectangle.js index 52b0053..636e8f4 100644 --- a/src/core/graphics/webgl/utils/buildRoundedRectangle.js +++ b/src/core/graphics/webgl/utils/buildRoundedRectangle.js @@ -93,7 +93,7 @@ * @param [out] {number[]} The output array to add points into. If not passed, a new array is created. * @return {number[]} an array of points */ -let quadraticBezierCurve = function (fromX, fromY, cpX, cpY, toX, toY, out)// jshint ignore:line +let quadraticBezierCurve = function (fromX, fromY, cpX, cpY, toX, toY, out) { let xa, ya, @@ -130,4 +130,4 @@ return points; }; -export default buildRoundedRectangle; \ No newline at end of file +export default buildRoundedRectangle; diff --git a/src/core/math/Matrix.js b/src/core/math/Matrix.js index 0e90543..b74f3a7 100644 --- a/src/core/math/Matrix.js +++ b/src/core/math/Matrix.js @@ -1,7 +1,3 @@ -// @todo - ignore the too many parameters warning for now -// should either fix it or change the jshint config -// jshint -W072 - import Point from './Point'; /** @@ -491,4 +487,4 @@ } } -export default Matrix; \ No newline at end of file +export default Matrix; diff --git a/src/core/renderers/webgl/managers/FilterManager.js b/src/core/renderers/webgl/managers/FilterManager.js index f1d5a99..bf59404 100644 --- a/src/core/renderers/webgl/managers/FilterManager.js +++ b/src/core/renderers/webgl/managers/FilterManager.js @@ -440,4 +440,4 @@ } } -export default FilterManager; \ No newline at end of file +export default FilterManager; diff --git a/src/core/renderers/webgl/utils/validateContext.js b/src/core/renderers/webgl/utils/validateContext.js index d1f83e7..34d4c88 100644 --- a/src/core/renderers/webgl/utils/validateContext.js +++ b/src/core/renderers/webgl/utils/validateContext.js @@ -5,8 +5,8 @@ // this is going to be fairly simple for now.. but at least we have rom to grow! if(!attributes.stencil) { - console.warn('Provided WebGL context does not have a stencil buffer, masks may not render correctly'); // jshint ignore:line + console.warn('Provided WebGL context does not have a stencil buffer, masks may not render correctly'); } } -export default validateContext; \ No newline at end of file +export default validateContext; diff --git a/src/core/textures/RenderTexture.js b/src/core/textures/RenderTexture.js index 38233d5..f0a6382 100644 --- a/src/core/textures/RenderTexture.js +++ b/src/core/textures/RenderTexture.js @@ -55,7 +55,7 @@ let resolution = arguments[4] || 1; // we have an old render texture.. - console.warn('v4 RenderTexture now expects a new BaseRenderTexture. Please use RenderTexture.create('+width+', '+height+')'); // jshint ignore:line + console.warn(`v4 RenderTexture now expects a new BaseRenderTexture. Please use RenderTexture.create(${width}, ${height})`); _legacyRenderer = arguments[0]; frame = null; @@ -122,4 +122,4 @@ } } -export default RenderTexture; \ No newline at end of file +export default RenderTexture; diff --git a/src/core/utils/index.js b/src/core/utils/index.js index f6ebb8d..07426e1 100644 --- a/src/core/utils/index.js +++ b/src/core/utils/index.js @@ -123,11 +123,11 @@ 'color: #ff2424; background: #fff; padding:5px 0;' ]; - window.console.log.apply(console, args); //jshint ignore:line + window.console.log.apply(console, args); } else if (window.console) { - window.console.log('Pixi.js ' + CONST.VERSION + ' - ' + type + ' - http://www.pixijs.com/'); //jshint ignore:line + window.console.log(`Pixi.js ${CONST.VERSION} - ${type} - http://www.pixijs.com/`); } utils._saidHello = true;