diff --git a/packages/core/src/geometry/GeometrySystem.js b/packages/core/src/geometry/GeometrySystem.js index 3c56989..58d5fe5 100644 --- a/packages/core/src/geometry/GeometrySystem.js +++ b/packages/core/src/geometry/GeometrySystem.js @@ -148,9 +148,9 @@ /** * Binds geometry so that is can be drawn. Creating a Vao if required - * @protected + * * @param {PIXI.Geometry} geometry instance of geometry to bind - * @param {PIXI.Shader} shader instance of shader to bind + * @param {PIXI.Shader} [shader] instance of shader to use vao for */ bind(geometry, shader) { diff --git a/packages/core/src/geometry/GeometrySystem.js b/packages/core/src/geometry/GeometrySystem.js index 3c56989..58d5fe5 100644 --- a/packages/core/src/geometry/GeometrySystem.js +++ b/packages/core/src/geometry/GeometrySystem.js @@ -148,9 +148,9 @@ /** * Binds geometry so that is can be drawn. Creating a Vao if required - * @protected + * * @param {PIXI.Geometry} geometry instance of geometry to bind - * @param {PIXI.Shader} shader instance of shader to bind + * @param {PIXI.Shader} [shader] instance of shader to use vao for */ bind(geometry, shader) { diff --git a/packages/core/src/textures/BaseTexture.js b/packages/core/src/textures/BaseTexture.js index 883d271..5940a0e 100644 --- a/packages/core/src/textures/BaseTexture.js +++ b/packages/core/src/textures/BaseTexture.js @@ -179,8 +179,9 @@ /** * Used by TextureSystem to only update texture to the GPU when needed. + * Please call `update()` to increment it. * - * @protected + * @readonly * @member {number} */ this.dirtyId = 0; diff --git a/packages/core/src/geometry/GeometrySystem.js b/packages/core/src/geometry/GeometrySystem.js index 3c56989..58d5fe5 100644 --- a/packages/core/src/geometry/GeometrySystem.js +++ b/packages/core/src/geometry/GeometrySystem.js @@ -148,9 +148,9 @@ /** * Binds geometry so that is can be drawn. Creating a Vao if required - * @protected + * * @param {PIXI.Geometry} geometry instance of geometry to bind - * @param {PIXI.Shader} shader instance of shader to bind + * @param {PIXI.Shader} [shader] instance of shader to use vao for */ bind(geometry, shader) { diff --git a/packages/core/src/textures/BaseTexture.js b/packages/core/src/textures/BaseTexture.js index 883d271..5940a0e 100644 --- a/packages/core/src/textures/BaseTexture.js +++ b/packages/core/src/textures/BaseTexture.js @@ -179,8 +179,9 @@ /** * Used by TextureSystem to only update texture to the GPU when needed. + * Please call `update()` to increment it. * - * @protected + * @readonly * @member {number} */ this.dirtyId = 0; diff --git a/packages/core/src/textures/GLTexture.js b/packages/core/src/textures/GLTexture.js index 056343e..0168fe1 100644 --- a/packages/core/src/textures/GLTexture.js +++ b/packages/core/src/textures/GLTexture.js @@ -13,7 +13,16 @@ */ this.texture = texture; + /** + * Width of texture that was used in texImage2D + * @member {number} + */ this.width = -1; + + /** + * Height of texture that was used in texImage2D + * @member {number} + */ this.height = -1; /** diff --git a/packages/core/src/geometry/GeometrySystem.js b/packages/core/src/geometry/GeometrySystem.js index 3c56989..58d5fe5 100644 --- a/packages/core/src/geometry/GeometrySystem.js +++ b/packages/core/src/geometry/GeometrySystem.js @@ -148,9 +148,9 @@ /** * Binds geometry so that is can be drawn. Creating a Vao if required - * @protected + * * @param {PIXI.Geometry} geometry instance of geometry to bind - * @param {PIXI.Shader} shader instance of shader to bind + * @param {PIXI.Shader} [shader] instance of shader to use vao for */ bind(geometry, shader) { diff --git a/packages/core/src/textures/BaseTexture.js b/packages/core/src/textures/BaseTexture.js index 883d271..5940a0e 100644 --- a/packages/core/src/textures/BaseTexture.js +++ b/packages/core/src/textures/BaseTexture.js @@ -179,8 +179,9 @@ /** * Used by TextureSystem to only update texture to the GPU when needed. + * Please call `update()` to increment it. * - * @protected + * @readonly * @member {number} */ this.dirtyId = 0; diff --git a/packages/core/src/textures/GLTexture.js b/packages/core/src/textures/GLTexture.js index 056343e..0168fe1 100644 --- a/packages/core/src/textures/GLTexture.js +++ b/packages/core/src/textures/GLTexture.js @@ -13,7 +13,16 @@ */ this.texture = texture; + /** + * Width of texture that was used in texImage2D + * @member {number} + */ this.width = -1; + + /** + * Height of texture that was used in texImage2D + * @member {number} + */ this.height = -1; /** diff --git a/packages/display/src/DisplayObject.js b/packages/display/src/DisplayObject.js index 83f7ff9..3a701f9 100644 --- a/packages/display/src/DisplayObject.js +++ b/packages/display/src/DisplayObject.js @@ -705,5 +705,11 @@ } } -// performance increase to avoid using call.. (10x faster) +/** + * DisplayObject default updateTransform, does not update children of container. + * Will crash if there's no parent element. + * + * @memberof PIXI.DisplayObject# + * @function displayObjectUpdateTransform + */ DisplayObject.prototype.displayObjectUpdateTransform = DisplayObject.prototype.updateTransform;