diff --git a/src/mesh/geometry/Geometry.js b/src/mesh/geometry/Geometry.js index e8788be..1bfe793 100644 --- a/src/mesh/geometry/Geometry.js +++ b/src/mesh/geometry/Geometry.js @@ -77,9 +77,9 @@ */ addAttribute(id, buffer, size, normalised = false, type, stride, start) { - if(!buffer) + if (!buffer) { - buffer = new Float32Array(2); + throw new Error('You must pass a buffer when creating an attribute'); } // check if this is a buffer! diff --git a/src/mesh/geometry/Geometry.js b/src/mesh/geometry/Geometry.js index e8788be..1bfe793 100644 --- a/src/mesh/geometry/Geometry.js +++ b/src/mesh/geometry/Geometry.js @@ -77,9 +77,9 @@ */ addAttribute(id, buffer, size, normalised = false, type, stride, start) { - if(!buffer) + if (!buffer) { - buffer = new Float32Array(2); + throw new Error('You must pass a buffer when creating an attribute'); } // check if this is a buffer! diff --git a/src/mesh/webgl/MeshRenderer.js b/src/mesh/webgl/MeshRenderer.js index fbc6918..eaa0279 100644 --- a/src/mesh/webgl/MeshRenderer.js +++ b/src/mesh/webgl/MeshRenderer.js @@ -124,7 +124,6 @@ const buffers = geometry.buffers; const attributes = geometry.attributes; - console.log(geometry.attributes) // first update - and create the buffers! for (let i = 0; i < buffers.length; i++) { @@ -166,10 +165,10 @@ for (const j in attributes) { - let attribute = attributes[j]; - let glAttribute = glShader.attributes[j]; + const attribute = attributes[j]; + const glAttribute = glShader.attributes[j]; - if(attribute.stride === undefined) + if (attribute.stride === undefined) { if (tempStride[attribute.buffer] === glAttribute.size * byteSizeMap[attribute.type]) { @@ -181,7 +180,7 @@ } } - if(attribute.start === undefined) + if (attribute.start === undefined) { attribute.start = tempStart[attribute.buffer]; @@ -189,7 +188,6 @@ } } - // next update the attributes buffer.. for (const j in attributes) { @@ -210,7 +208,6 @@ geometry.glVertexArrayObjects[this.CONTEXT_UID] = vao; - console.log(vao); return vao; } }